New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a new language #529

Open

catalinux opened this issue Aug 20, 2023 · 1 comment

catalinux commented Aug 20, 2023

Is there any guide for adding a new language?

My thinks is to the the following

copy folders en for tests and source for new language
changing tests and updatinng the code till tests will pass

Any other issues I might look into?

Owner

wanasit commented Sep 2, 2023 •

edited

Hello @catalinux. Thanks for reaching out.

What you described is correct. Just follow the English example:
You can also look into previous new language PR (e.g. #519).

However, the only thing I would like to ask is please make small incremental CRs.

Don't try to support every pattern at once.
It's ok to start with a near-empty setup. Then, add a only few parsers (and tests) at a time.
Small CRs would be easier to test and review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment