Support for Ukrainian (uk) #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bootseller
commented
Jul 4, 2023
bootseller
commented
- added support for Ukrainian
- added the corresponding tests
|
Hello, @bootseller. Thanks for the improvement and sorry for my slow reply. I'll review this today, but note that it may take time because the change is large. Next time, I'd recommend breaking the changes into smaller pieces (e.g. just minimum config, one pattern at a time) rather than submitting the all pattern translation at once. Anyway thanks again for your help. |
wanasit
approved these changes
Jul 8, 2023
|
The automated test failed because of the package config in the main branch. If you could rebase to the latest master, the test should pass. |
|
Thank you so much for looking into my PR. I think I did everything you asked for. Do let me know if I need to implement anything else. |
|
@bootseller Thank you! 🇺🇦🇺🇦🇺🇦 |
|
This change has been included in v2.6.4. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.