Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main branch failing test. #538

Open
HendrikJan opened this issue Nov 13, 2023 · 3 comments
Open

Main branch failing test. #538

HendrikJan opened this issue Nov 13, 2023 · 3 comments

Comments

@HendrikJan
Copy link
Contributor

Hi,

I'm trying to create a PR for a minor improvement for the Dutch language.

Unfortunately I cannot create a commit because Husky won't let me.
Husky won't let me because the test "Compare with native js" fails.

Should I wait for a fix for this test before creating a PR?

Kind regards,
Hendrik Jan

@HendrikJan
Copy link
Contributor Author

I've now created a PR using "--no-verify", but questing remains if I should wait for the test to pass.

@wanasit
Copy link
Owner

wanasit commented Nov 19, 2023

Hello @HendrikJan.

Could you share more specific details about the cases that are failing? or what error message do you get?

@HendrikJan
Copy link
Contributor Author

HendrikJan commented Nov 20, 2023

The error I get is this:
image

Since you already accepted my PR this failing test is not blocking me anymore (therefore I updated the title of this issue).

@HendrikJan HendrikJan changed the title Main branch failing tests, preventing me from making PR Main branch failing tests. Nov 20, 2023
@HendrikJan HendrikJan changed the title Main branch failing tests. Main branch failing test. Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants