Loosen moment dependency #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loosen the moment dependency so that downstream libraries can choose which version of moment to use.
1 task
1 similar comment
|
Thanks for the improvement! |
|
@wanasit Thanks for landing this! Could you please release a new version to npm so we can take advantage of the change? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loosen the moment dependency so that downstream libraries can choose which version of moment to use.
Currently, consumers are forced to use
moment@2.21.0if they usechrono-node, even if they're already using a more recent version. This causes moment, which uses a stateful singleton for things like the default locale, to load and initialize more than once.