Implemented '本年' '今年' (this year) form for Japanese. #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know this PR will conflict with #297. |
|
Thanks for the improvement! |
|
🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'本年7月27日' and '今年7月27日' form is used to express 'July 27th of this year' in Japanese.
This usage is exactly the same as the usage of '同年', which is already implemented in chrono.
(These 3 expressions differ in politeness and other kinds of contexts.
ref(本年): https://www.kantei.go.jp/jp/headline/gotaii_gosokui/sikiten.html
ref(本年): https://www.mhlw.go.jp/content/12400000/000475441.pdf
ref(今年): https://www.sankei.com/west/news/190323/wst1903230023-n1.html