[EN] Fix for multiple time units within parser (e.g. set a timer for 5 minutes and 30 seconds) #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ser with forward dates
wanasit
reviewed
Dec 23, 2023
| expect(result.start).toBeDate(new Date(2012, 7, 10, 12, 19, 30)); | ||
| }); | ||
|
|
||
| testSingleCase(chrono, "set a timer for 10 minutes and 10 seconds", new Date(2012, 7, 10, 12, 14), { forwardDate: true }, (result) => { |
There was a problem hiding this comment.
I would also test a combination of both comma + and e.g. "1 hour, 10 minutes, and 10 seconds".
wanasit
requested changes
Dec 23, 2023
There was a problem hiding this comment.
Hello @trothe. Thanks for your improvement!
However, I think adding the connection word in the parser pattern is not the best way to fix the problem (e.g. we also want to support other parsers e.g. "5 minutes AND 30 seconds ago"). Instead, we should fix the TIME_UNIT_PATTERN in constants.ts.
I would:
- Update
repeatedTimeunitPatternto take a connector as a parameter (with the current pattern as default). - For English constant, we use the current pattern plus your new connector.
Sorry if my request is too difficult.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into issues with phrases like "for 5 minutes AND 30 seconds". It seems the regex didn't capture the second time unit. I updated the regex to capture multiple time units in ENTimeUnitWithinFormatParser. I also added a test case. I hope this is acceptable. If not let me know.