Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parseDate return type not nullable #544

Merged
merged 1 commit into from Jan 20, 2024

Conversation

goodoldneon
Copy link
Contributor

@goodoldneon goodoldneon commented Jan 15, 2024

Fix parseDate returning Date instead of Date | null in its types.

Setting "strictNullChecks": true in tsconfig.json will prevent regressions, but that requires some refactoring to satisfy. There are a handful of places that:

  • Expect null but get a value that could be undefined
  • Expect undefined but get a value that could be null
  • Expect a non-nullish type but get a value that could be nullish

@coveralls
Copy link

Coverage Status

coverage: 91.378%. remained the same
when pulling 3126f44 on goodoldneon:fix-parseDate-type
into 1f9f741 on wanasit:master.

@wanasit wanasit merged commit b4e1d43 into wanasit:master Jan 20, 2024
2 checks passed
@wanasit
Copy link
Owner

wanasit commented Jan 20, 2024

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants