add host into rundata, cuz thats where it belongs

wandb · Jul 19, 2020 · eb0a438 · eb0a438
1 parent cc3da21
commit eb0a438
Show file tree

Hide file tree

Showing 4 changed files with 57 additions and 48 deletions.
diff --git a/wandb/interface/interface.py b/wandb/interface/interface.py
@@ -79,6 +79,7 @@ def _make_run(self, run):
         proto_run = wandb_internal_pb2.RunData()
         run._make_proto_run(proto_run)
         proto_run.start_time.GetCurrentTime()
+        proto_run.host = run._settings.host
         if run._config is not None:
             config_dict = run._config._as_dict()
             self._make_config(config_dict, obj=proto_run.config)

diff --git a/wandb/internal/sender.py b/wandb/internal/sender.py
@@ -40,7 +40,7 @@ def _config_dict_from_proto_list(obj_list):
 
 
 class SendManager(object):
-    def __init__(self, settings, resp_q, run_meta):
+    def __init__(self, settings, resp_q, run_meta=None):
         self._settings = settings
         self._resp_q = resp_q
         self._run_meta = run_meta
@@ -122,7 +122,7 @@ def handle_run(self, data):
             tags=run_tags or None,
             config=config_dict or None,
             sweep_name=run.sweep_id or None,
-            host=self._settings.host or None,
+            host=run.host or None,
         )
 
         if data.control.req_resp:

diff --git a/wandb/proto/wandb_internal.proto b/wandb/proto/wandb_internal.proto
@@ -46,6 +46,7 @@ message RunData {
   repeated string tags = 10;
   SettingsData settings = 11;
   string sweep_id = 12;
+  string host = 13;
 
   string storage_id = 16;
   google.protobuf.Timestamp start_time = 17;

diff --git a/wandb/proto/wandb_internal_pb2.py b/wandb/proto/wandb_internal_pb2.py