This repository has been archived by the owner on Sep 24, 2020. It is now read-only.
allow programmatic updates of artifact description, metadata, aliases #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5abe3d2d-465c-4b5b-8fcd-c62f2cb999d0
💛 - Coveralls |
raubitsj
approved these changes
Sep 14, 2020
vanpelt
suggested changes
Sep 14, 2020
wandb/apis/public.py
Outdated
| self._metadata = self._attrs.get("metadata", None) | ||
| self._description = self._attrs.get("description", None) | ||
| self._sequence_name = self._attrs["artifactSequence"]["name"] | ||
| self._version_index = self._attrs["versionIndex"] |
There was a problem hiding this comment.
Should we default this to 0 if we don't have a versionIndex
There was a problem hiding this comment.
Because of the way the API works, you can only resolve artifacts that have been committed and consequently have a versionIndex, however a default might still be good here.
vanpelt
approved these changes
Sep 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.