Skip to content
This repository has been archived by the owner on Sep 24, 2020. It is now read-only.

app.wandb.ai => wandb.ai #223

Merged
merged 3 commits into from
Sep 17, 2020
Merged

app.wandb.ai => wandb.ai #223

merged 3 commits into from
Sep 17, 2020

Conversation

vanpelt
Copy link
Contributor

@vanpelt vanpelt commented Sep 17, 2020

And DRY'd up the logic

return api_url.replace('api.', 'app.')
# Unexpected
return api_url
return wandb.util.app_url(self.api_url)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need On-prem VM anymore, and my new logic covers the wandb.test case.

Copy link
Contributor

@cvphelps cvphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this, I'm using the auto-login constantly in colab

@coveralls
Copy link

coveralls commented Sep 17, 2020

Pull Request Test Coverage Report for Build c51e6a69-70e0-4779-b594-7ccde8e6ee2c

  • 9 of 12 (75.0%) changed or added relevant lines in 6 files are covered.
  • 971 unchanged lines in 49 files lost coverage.
  • Overall coverage decreased (-4.02%) to 61.049%

Changes Missing Coverage Covered Lines Changed/Added Lines %
wandb/apis/internal_runqueue.py 0 1 0.0%
wandb/lib/apikey.py 1 2 50.0%
wandb/sdk/wandb_run.py 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
tests/utils/mock_server.py 1 84.65%
wandb/apis/internal_runqueue.py 1 25.45%
wandb/internal/internal.py 1 27.89%
wandb/internal/meta.py 1 72.39%
wandb/internal/run.py 1 61.54%
wandb/lib/ipython.py 1 71.43%
wandb/old/core.py 1 57.63%
wandb/sdk/wandb_config.py 1 69.72%
wandb/sdk/wandb_login.py 1 91.04%
wandb/sweeps/base.py 1 80.0%
Totals Coverage Status
Change from base Build 3fb5f0f8-2f15-4a7c-93f0-ab35155f1163: -4.02%
Covered Lines: 12935
Relevant Lines: 21188

💛 - Coveralls

@raubitsj raubitsj merged commit a9e4ad3 into master Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants