Parallel artifact writers #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1705 +/- ##
==========================================
+ Coverage 69.67% 69.74% +0.06%
==========================================
Files 222 222
Lines 25861 25958 +97
==========================================
+ Hits 18019 18104 +85
- Misses 7842 7854 +12
Continue to review full report at Codecov.
|
annirudh
commented
Jan 26, 2021
| test_joined_table_referential, | ||
| test_joined_table_add_by_path, | ||
| test_image_reference_with_preferred_path, | ||
| # test_artifact_add_reference_via_url, |
There was a problem hiding this comment.
@tssweeney Do we want to uncomment these before merging?
There was a problem hiding this comment.
yes, and we should run the regression. this was a leftover.
There was a problem hiding this comment.
OK, I will uncomment.
…into artifacts/parallel
tssweeney
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.