New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel artifact writers #1705
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1705 +/- ##
==========================================
+ Coverage 69.67% 69.74% +0.06%
==========================================
Files 222 222
Lines 25861 25958 +97
==========================================
+ Hits 18019 18104 +85
- Misses 7842 7854 +12
Continue to review full report at Codecov.
|
test_joined_table_referential, | ||
test_joined_table_add_by_path, | ||
test_image_reference_with_preferred_path, | ||
# test_artifact_add_reference_via_url, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tssweeney Do we want to uncomment these before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, and we should run the regression. this was a leftover.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I will uncomment.
…into artifacts/parallel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but since we worked together on this, might need one other set of eyes
No description provided.