Delete namespace.yaml

* Namespace should be created with --create-namespace per helm/helm#3503
* Fixed some SA bugs to work with Terraform wrapper.

charts/launch-agent/Chart.yaml

@@ -3,7 +3,7 @@ name: launch-agent
 icon: https://em-content.zobj.net/thumbs/240/apple/354/rocket_1f680.png
 description: A Helm chart for running the W&B Launch Agent in Kubernetes
 type: application
-version: 0.7.0
+version: 0.8.0
 maintainers:
   - name: wandb
     email: support@wandb.com

charts/launch-agent/templates/rbac.yaml

@@ -4,11 +4,10 @@ kind: ServiceAccount
 metadata:
   name: wandb-launch-serviceaccount
   namespace: {{ .Values.namespace }}
-{{ if .Values.serviceAccount.annotations }}
+{{- if .Values.serviceAccount.annotations }}
   annotations:
-{{ toYaml .Values.serviceAccount.annotations | indent 4 }}
-{{ end }}
-...
+{{- toYaml .Values.serviceAccount.annotations | nindent 4 }}
+{{- end }}
 ---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: Role
@@ -53,8 +52,10 @@ roleRef:
   name: wandb-launch-agent
   apiGroup: rbac.authorization.k8s.io
 ...
+{{- define "unique.namespaces" }}
 {{- $root := . -}}
-{{- range $ns := append .Values.additionalTargetNamespaces .Values.namespace }}
+{{- $unique := uniq (append .Values.additionalTargetNamespaces .Values.namespace) }}
+{{- range $ns := $unique }}
 ---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
@@ -70,4 +71,7 @@ roleRef:
   name: job-creator
   apiGroup: rbac.authorization.k8s.io
 ...
-{{- end }}
+{{- end }}
+{{- end }}
+
+{{ include "unique.namespaces" . }}

charts/launch-agent/values.yaml

@@ -37,8 +37,8 @@ gitCreds: |
 # Annotations for the wandb service account. Useful when setting up workload identity on gcp.
 serviceAccount:
   annotations:
-    iam.gke.io/gcp-service-account:
-    azure.workload.identity/client-id:
+    # iam.gke.io/gcp-service-account:
+    # azure.workload.identity/client-id:
 
 # Set to access key for azure storage if using kaniko with azure.
 azureStorageAccessKey: ""