Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting used with gloang #1

Merged
merged 5 commits into from
Jan 24, 2023
Merged

Getting used with gloang #1

merged 5 commits into from
Jan 24, 2023

Conversation

flamarion
Copy link
Contributor

This is my first time with Golang after some introductory training and a lot of Stackoverflow "research".
I want to get a review before moving forward to avoid too many items to fix.

pkg/deployments/utils.go Outdated Show resolved Hide resolved
templates/cloud_aws.tf Outdated Show resolved Hide resolved
@flamarion
Copy link
Contributor Author

Is it ok to create a General section in the yaml like the example below?

    production:
        engine: Terraform
        platform: Amazon Web Services
        private-cloud:
            general:
                namespace: dad
                region: us-east-1
                enableredis: true
                useinternalqueue: false

If it's ok, I will move all general configurations to there.

@flamarion flamarion requested a review from jsbroks January 3, 2023 15:29
@venky-wandb
Copy link

Looks good to me! 👍

@flamarion flamarion merged commit 5a4422f into main Jan 24, 2023
@flamarion flamarion deleted the getting_used_with_gloang branch January 24, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants