Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Defaults to MySQL 8 #8

Merged
merged 4 commits into from
Apr 11, 2022
Merged

feat: Defaults to MySQL 8 #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b062052
feat: Defaults to MySQL 8
jsbroks Apr 11, 2022
fe7cb7f
terraform-docs: automated action
github-actions[bot] Apr 11, 2022
e2a848c
regenerate pet name on database change
jsbroks Apr 11, 2022
a6104e5
Merge branch 'justin/mysql-8' of https://github.com/wandb/terraform-g…
jsbroks Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ No resources.

| Name | Description | Type | Default | Required |
|------|-------------|------|---------|:--------:|
| <a name="input_database_version"></a> [database\_version](#input\_database\_version) | Version for MySQL | `string` | `"MYSQL_5_7"` | no |
| <a name="input_database_version"></a> [database\_version](#input\_database\_version) | Version for MySQL | `string` | `"MYSQL_8_0"` | no |
| <a name="input_deletion_protection"></a> [deletion\_protection](#input\_deletion\_protection) | If the instance should have deletion protection enabled. The database / Bucket can't be deleted when this value is set to `true`. | `bool` | `true` | no |
| <a name="input_domain_name"></a> [domain\_name](#input\_domain\_name) | Domain for accessing the Weights & Biases UI. | `string` | `null` | no |
| <a name="input_labels"></a> [labels](#input\_labels) | Labels to apply to resources | `map(string)` | `{}` | no |
Expand Down
3 changes: 3 additions & 0 deletions modules/database/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ resource "random_string" "master_password" {

resource "random_pet" "mysql" {
length = 2
keepers = {
version = var.database_version
}
}

locals {
Expand Down
2 changes: 1 addition & 1 deletion modules/database/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ variable "labels" {
variable "database_version" {
description = "Version for MySQL"
type = string
default = "MYSQL_5_7"
default = "MYSQL_8_0"

validation {
condition = contains(["MYSQL_5_7", "MYSQL_8_0"], var.database_version)
Expand Down
2 changes: 1 addition & 1 deletion variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ variable "ssl" {
variable "database_version" {
description = "Version for MySQL"
type = string
default = "MYSQL_5_7"
default = "MYSQL_8_0"

validation {
condition = contains(["MYSQL_5_7", "MYSQL_8_0"], var.database_version)
Expand Down