Skip to content

Commit

Permalink
[DRAFT] The gRPC server now has the port option that allows to specif…
Browse files Browse the repository at this point in the history
…y the se… (#1681)

* The gRPC server now has the port option that allows to specify the server's listening port. (#1677)
Co-authored-by: Erik Fäßler <chew@gmx.net>
  • Loading branch information
raubitsj committed Jan 9, 2021
1 parent 238d3a6 commit ec99dfe
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
7 changes: 4 additions & 3 deletions wandb/cli/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -242,19 +242,20 @@ def login(key, host, cloud, relogin, anonymously, no_offline=False):
@cli.command(
context_settings=CONTEXT, help="Run a grpc server", name="grpc-server", hidden=True
)
@click.option("--port", default=None, help="The host port to bind grpc service.")
@display_error
def grpc_server(project=None, entity=None):
def grpc_server(project=None, entity=None, port=None):
_ = util.get_module(
"grpc",
required="grpc-server requires the grpcio library, run pip install wandb[grpc]",
)
from wandb.server.grpc_server import main as grpc_server

grpc_server()
grpc_server(port=port)


@cli.command(context_settings=CONTEXT, help="Run a SUPER agent", hidden=True)
@click.option("--project", "-p", default=None, help="The project use.")
@click.option("--project", "-p", default=None, help="The project to use.")
@click.option("--entity", "-e", default=None, help="The entity to use.")
@click.argument("agent_spec", nargs=-1)
@display_error
Expand Down
8 changes: 4 additions & 4 deletions wandb/server/grpc_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,13 +164,13 @@ def cleanup(self):
# No printing allowed from here until redirect restore!!!


def serve(backend):
def serve(backend, port):
try:
server = grpc.server(futures.ThreadPoolExecutor(max_workers=10))
wandb_server_pb2_grpc.add_InternalServiceServicer_to_server(
InternalServiceServicer(server, backend), server
)
server.add_insecure_port("[::]:50051")
server.add_insecure_port("[::]:{}".format(port))
server.start()
server.wait_for_termination()
# print("server shutting down")
Expand All @@ -179,12 +179,12 @@ def serve(backend):
print("control-c")


def main():
def main(port=None):
try:
logging.basicConfig()
backend = Backend()
backend.setup()
serve(backend)
serve(backend, port or 50051)
except KeyboardInterrupt:
print("outer control-c")

Expand Down

0 comments on commit ec99dfe

Please sign in to comment.