Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py38 deprecation warnings #1503

Closed
stas00 opened this issue Nov 16, 2020 · 2 comments · Fixed by #1607
Closed

py38 deprecation warnings #1503

stas00 opened this issue Nov 16, 2020 · 2 comments · Fixed by #1607

Comments

@stas00
Copy link

stas00 commented Nov 16, 2020

Please kindly fix these for py38:

python3.8/site-packages/wandb/util.py:36: 
DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working
  from collections import namedtuple, Mapping, Sequence
python3.8/site-packages/wandb/vendor/graphql-core-1.1/graphql/type/directives.py:55: 
DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working
  assert isinstance(locations, collections.Iterable), 'Must provide locations for directive.'

the first one is just s/collections/collections.abc/, but the second one is an outdated package.

Thank you!

@tyomhak
Copy link

tyomhak commented Nov 17, 2020

Hey @stas00 , thank you for reporting this.
@vanpelt can you please take a look?

@SylvainLan
Copy link

Hi !
I'm new to wandb and got this warning as well, even after installed it through github and not pip.
The flagged file was wandb/vendor/watchdog/utils/bricks.py:175, do you want me to run a small PR ? I can take a look at the merged PR from above

egpbos added a commit to egpbos/client that referenced this issue Apr 28, 2021
As mentioned here wandb#1503 (comment), there is a new deprecation warning, caused by the vendoring of (an old version of) watchdog. This small fix removes that warning.
egpbos added a commit to egpbos/client that referenced this issue Apr 28, 2021
As mentioned here wandb#1503 (comment), there is a new deprecation warning, caused by the vendored version of watchdog. This small fix removes that warning. It uses the same `six` method used in wandb#1607.
raubitsj pushed a commit that referenced this issue May 4, 2021
As mentioned here #1503 (comment), there is a new deprecation warning, caused by the vendored version of watchdog. This small fix removes that warning. It uses the same `six` method used in #1607.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants