WB-6749: sklearn plot_calibration_curve breaks the provided model #2791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…user's model used for calibration fitting & unused variables. Code also raises an error if plot_calibration_curve is used for multi-class datasets. Only binary classification is supported at this moment.
…aks-the-provided-model
Codecov Report
@@ Coverage Diff @@
## master #2791 +/- ##
==========================================
+ Coverage 76.22% 76.24% +0.02%
==========================================
Files 178 178
Lines 26489 26487 -2
==========================================
+ Hits 20190 20196 +6
+ Misses 6299 6291 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kptkin
reviewed
Oct 19, 2021
…aks-the-provided-model
…aks-the-provided-model
…aks-the-provided-model
kptkin
approved these changes
Oct 22, 2021
…aks-the-provided-model
vanpelt
deleted the
WB-6749-sklearn-plot_calibration_curve-breaks-the-provided-model
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wandb.atlassian.net/browse/WB-6749
wandb.sklearn.plot_calibration_curveincluded a fake dataset generation step (with 20 features), and used the user's model in the calibration fitting step on this fake dataset. This caused the model to break when user tried to use it on their original dataset (with 11 features).Description
Removed fake dataset generation and other unnecessary code including user's model used for calibration fitting & unused variables. Code also raises an error if plot_calibration_curve is used for multi-class datasets. Only binary classification is supported at this moment.
Testing
Tested manually.
Release Notes
Below, please enter user-facing release notes as one or more bullet points.
If your change is not user-visible, write
NO RELEASE NOTESinstead, with no bullet points.------------- BEGIN RELEASE NOTES ------------------
NO RELEASE NOTES
------------- END RELEASE NOTES --------------------