Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WB-7222] Bugfix: Fix use artifact #2832

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

KyleGoyette
Copy link
Contributor

@KyleGoyette KyleGoyette commented Oct 25, 2021

Fixes WB-7222

Description

Fixes an issue I introduced that broke use_artifact when using any artifact outside your current project

Testing

Release Notes

Below, please enter user-facing release notes as one or more bullet points.
If your change is not user-visible, write NO RELEASE NOTES instead, with no bullet points.

------------- BEGIN RELEASE NOTES ------------------

  • fix use_artifact

------------- END RELEASE NOTES --------------------

@KyleGoyette KyleGoyette changed the title fix use artifact Bugfix: Fix use artifact Oct 25, 2021
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #2832 (b1cc0d9) into master (7d69938) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2832      +/-   ##
==========================================
+ Coverage   76.26%   76.29%   +0.03%     
==========================================
  Files         178      178              
  Lines       26552    26552              
==========================================
+ Hits        20250    20259       +9     
+ Misses       6302     6293       -9     
Flag Coverage Δ
functest 51.04% <ø> (+0.03%) ⬆️
unittest 70.48% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/wandb_run.py 87.50% <ø> (+0.26%) ⬆️
wandb/sdk/lib/redirect.py 86.53% <0.00%> (-0.18%) ⬇️
wandb/sdk/lib/git.py 75.86% <0.00%> (ø)
wandb/filesync/step_prepare.py 94.28% <0.00%> (+1.42%) ⬆️
wandb/sdk/internal/meta.py 90.18% <0.00%> (+3.06%) ⬆️

@raubitsj raubitsj merged commit 391d414 into master Oct 26, 2021
@raubitsj raubitsj changed the title Bugfix: Fix use artifact [WB-7222] Bugfix: Fix use artifact Oct 27, 2021
@vanpelt vanpelt deleted the bugfix/use-artifact-other-project-support branch January 28, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants