[WB-6947] Flush log data without finish with service #3137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3137 +/- ##
==========================================
+ Coverage 79.90% 79.96% +0.06%
==========================================
Files 213 212 -1
Lines 27882 27908 +26
==========================================
+ Hits 22278 22316 +38
+ Misses 5604 5592 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kptkin
commented
Jan 14, 2022
kptkin
commented
Jan 14, 2022
raubitsj
reviewed
Feb 2, 2022
raubitsj
reviewed
Feb 2, 2022
raubitsj
reviewed
Feb 2, 2022
raubitsj
approved these changes
Feb 22, 2022
| @@ -96,9 +92,6 @@ def add_log_hooks_to_pytorch_module( | |||
| if name is not None: | |||
| prefix = prefix + name | |||
|
|
|||
| if jupyter_run: | |||
There was a problem hiding this comment.
Im just curious. did you look into why this was here and what it was accomplishing before?
There was a problem hiding this comment.
I couldn't find what is was doing... I saw it is used to recover history...
I guess I can keep it and just use it as a run... (if provided)
I did a simple example in a Notebook without it and it worked, but it's not a guarantee
kptkin
commented
Feb 22, 2022
| model, | ||
| log_parameters=log_parameters, | ||
| log_gradients=log_gradients, | ||
| prefix=prefix, | ||
| log_freq=log_freq, | ||
| jupyter_run=wandb.run if in_jupyter else None, |
There was a problem hiding this comment.
it is using the same wandb.run so that's why i though it's ok to remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WB-6947
Description
What does the PR do?
This PR moves the partial history logic to the internal process. This PR allows for runs that use the
wandb-servicepath to flush their remaining history without explicitly callingwandb.finish.This is the first PR in series of PR that move the step tracking logic from the user process to the internal process.
Testing
How was this PR tested?
This PR should keep functionality, it is tested using the existing tests.
Checklist