Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WB-8055] Fix issue logging images with "/" on Windows #3146

Merged
merged 16 commits into from
Feb 23, 2022

Conversation

KyleGoyette
Copy link
Contributor

@KyleGoyette KyleGoyette commented Jan 14, 2022

Fixes WB-8055

Description

Fixes a regression I introduced to allow users on windows to log files in different directories using "/"

Testing

Adds a test for this case

Checklist

  • Name PR "[WB-NNNN][WB-MMMM] Add support for..." similar to entries in CHANGELOG.md
  • Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #3146 (02098e9) into master (06ced64) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3146      +/-   ##
==========================================
+ Coverage   80.00%   80.03%   +0.02%     
==========================================
  Files         213      213              
  Lines       28039    28039              
==========================================
+ Hits        22433    22440       +7     
+ Misses       5606     5599       -7     
Flag Coverage Δ
functest 56.65% <100.00%> (ø)
unittest 69.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/util.py 85.58% <100.00%> (ø)
wandb/sdk/internal/sender.py 91.46% <0.00%> (-0.28%) ⬇️
wandb/sdk/lib/git.py 76.35% <0.00%> (ø)
wandb/sdk/wandb_run.py 88.75% <0.00%> (+0.27%) ⬆️
wandb/sdk/internal/meta.py 90.74% <0.00%> (+3.08%) ⬆️

@KyleGoyette KyleGoyette changed the title remove dir separator [WB-8055] Fix issue logging images with "/" on Windows Jan 20, 2022
@KyleGoyette KyleGoyette marked this pull request as ready for review January 20, 2022 16:22
@raubitsj raubitsj added this to the sdk-2022-03.1 milestone Feb 18, 2022
Copy link
Member

@raubitsj raubitsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 character change, 4 new tests! perfect ratio

@raubitsj raubitsj merged commit e64c0e2 into master Feb 23, 2022
@raubitsj raubitsj deleted the bugix/invalid-windows-path-fix branch February 23, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants