Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WB-8243] Add captions to Molecules #3173

Merged
merged 7 commits into from
Feb 1, 2022
Merged

[WB-8243] Add captions to Molecules #3173

merged 7 commits into from
Feb 1, 2022

Conversation

dmitryduev
Copy link
Member

@dmitryduev dmitryduev commented Jan 26, 2022

Fixes WB-8243

Description

Add the ability to set captions on wandb.Molecule objects.

Testing

How was this PR tested?

Checklist

  • Name PR "[WB-NNNN][WB-MMMM] Add support for..." similar to entries in CHANGELOG.md
  • Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #3173 (cbe56b8) into master (67b8208) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3173      +/-   ##
==========================================
+ Coverage   79.03%   79.06%   +0.03%     
==========================================
  Files         210      210              
  Lines       27658    27659       +1     
==========================================
+ Hits        21859    21869      +10     
+ Misses       5799     5790       -9     
Flag Coverage Δ
functest 57.17% <33.33%> (+0.05%) ⬆️
unittest 68.91% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/wandb_run.py 87.87% <ø> (+0.26%) ⬆️
wandb/sdk/data_types.py 84.34% <100.00%> (+0.01%) ⬆️
wandb/sdk/lib/sock_client.py 92.85% <0.00%> (-1.79%) ⬇️
wandb/filesync/step_prepare.py 92.85% <0.00%> (-1.43%) ⬇️
wandb/sdk/internal/stats.py 67.22% <0.00%> (-0.56%) ⬇️
wandb/sdk/internal/sender.py 91.44% <0.00%> (-0.28%) ⬇️
wandb/sdk/lib/git.py 76.35% <0.00%> (ø)
wandb/util.py 74.05% <0.00%> (+0.48%) ⬆️
wandb/sdk/internal/meta.py 90.74% <0.00%> (+3.08%) ⬆️
... and 1 more

@dmitryduev dmitryduev changed the title Add captions to Molecules [WB-8243] Add captions to Molecules Jan 26, 2022
@dmitryduev dmitryduev marked this pull request as ready for review January 26, 2022 19:20
Copy link

@captain-pool captain-pool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tssweeney tssweeney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice catch. Did you test this in the UI? Would be good to close the loop to make sure this is not only a code-correctness fix, but also respected in the media panel.

@dmitryduev
Copy link
Member Author

dmitryduev commented Feb 1, 2022

@tssweeney: @captain-pool tested that and it's actually broken :)

@dmitryduev dmitryduev merged commit 3c9cdc0 into master Feb 1, 2022
@dmitryduev dmitryduev deleted the mol-caption branch February 1, 2022 03:07
@raubitsj raubitsj added this to the sdk-2022-03.1 milestone Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants