-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WB-8243] Add captions to Molecules #3173
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3173 +/- ##
==========================================
+ Coverage 79.03% 79.06% +0.03%
==========================================
Files 210 210
Lines 27658 27659 +1
==========================================
+ Hits 21859 21869 +10
+ Misses 5799 5790 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - nice catch. Did you test this in the UI? Would be good to close the loop to make sure this is not only a code-correctness fix, but also respected in the media panel.
@tssweeney: @captain-pool tested that and it's actually broken :) |
Fixes WB-8243
Description
Add the ability to set captions on
wandb.Molecule
objects.Testing
How was this PR tested?
Checklist