Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WB-8176] Use Artifacts when put into run config. Accept a string to represent an artifact in the run config #3203

Merged
merged 28 commits into from
Feb 23, 2022

Conversation

KyleGoyette
Copy link
Contributor

@KyleGoyette KyleGoyette commented Feb 1, 2022

Fixes WB-8176

Description

What does the PR do?

Design doc

Testing

How was this PR tested?

Checklist

  • Name PR "[WB-NNNN][WB-MMMM] Add support for..." similar to entries in CHANGELOG.md
  • Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #3203 (9aff640) into master (e64c0e2) will increase coverage by 0.05%.
The diff coverage is 93.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3203      +/-   ##
==========================================
+ Coverage   79.99%   80.04%   +0.05%     
==========================================
  Files         213      213              
  Lines       28039    28089      +50     
==========================================
+ Hits        22430    22485      +55     
+ Misses       5609     5604       -5     
Flag Coverage Δ
functest 56.62% <36.50%> (-0.02%) ⬇️
unittest 69.48% <93.65%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/util.py 85.69% <90.00%> (+0.10%) ⬆️
wandb/sdk/wandb_run.py 88.69% <93.33%> (+0.22%) ⬆️
wandb/sdk/wandb_config.py 94.96% <100.00%> (+0.18%) ⬆️
wandb/sdk/wandb_init.py 85.17% <100.00%> (+0.15%) ⬆️
wandb/sdk/wandb_artifacts.py 81.57% <0.00%> (-0.11%) ⬇️
wandb/sdk/lib/git.py 76.35% <0.00%> (ø)
wandb/sdk/lib/sock_client.py 94.73% <0.00%> (+1.75%) ⬆️
wandb/sdk/internal/meta.py 90.74% <0.00%> (+3.08%) ⬆️

@KyleGoyette KyleGoyette changed the title Kyle/artifacts config 2 [WB-8176] Use Artifacts when put into run config. Accept a string to represent an artifact in the run config Feb 4, 2022
@KyleGoyette KyleGoyette marked this pull request as ready for review February 15, 2022 22:50
wandb/sdk/wandb_run.py Outdated Show resolved Hide resolved
wandb/util.py Outdated Show resolved Hide resolved
wandb/sdk/wandb_run.py Outdated Show resolved Hide resolved
Copy link
Contributor

@stephchen stephchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the logic in use_artifact is getting kinda convoluted and hard to follow but otherwise looks fine to me

@raubitsj raubitsj added this to the sdk-2022-03.1 milestone Feb 18, 2022
@raubitsj raubitsj merged commit 73e0c1c into master Feb 23, 2022
@raubitsj raubitsj deleted the kyle/artifacts-config-2 branch February 23, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants