Fix service performance issue during run shutdown #3262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3262 +/- ##
==========================================
+ Coverage 79.91% 79.95% +0.03%
==========================================
Files 213 213
Lines 27882 27882
==========================================
+ Hits 22282 22292 +10
+ Misses 5600 5590 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
(merging now to fix broken tests, any review comments will be done in a separate PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we shutdown a run we force close the queues and sockets so that reader threads do not hang.
The code as written was basically in a tight loop of error handling.. This should behave more as intended.
This shutdown of queues and sockets could still be cleaner in the future.
There is another performance issue still being tracked down, but this is the primary culprit.
Regarding coverage... normally the ValueError case should not be hit, typically you get a handle error (OSError) first but i think there are some cases where you could get the ValueError first, would have to do some careful error injection to hit all these cases.
Testing
Manually confirmed fix in regression
Checklist