Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WB-5747] wandb vendor gql and graphql #3266

Merged
merged 3 commits into from
Feb 20, 2022
Merged

[WB-5747] wandb vendor gql and graphql #3266

merged 3 commits into from
Feb 20, 2022

Conversation

raubitsj
Copy link
Member

@raubitsj raubitsj commented Feb 20, 2022

Fixes WB-5747
Fixes #3185

Description

Rename vendored modules gql and graphql to prevent conflict with users installed version.

Note:

  • Minimal changes were made: no package files or test files were updated.
  • A patch and markdown file added to each vendored directory wandb-vendor.md

TODO:

  • Fix up the yea-wandb change before merge (but after approval)

Testing

unittests and regression suite

Ran regression:

./do-cloud-regression.sh --cli_branch vendor-gql-graphql tests/main/

(all tests passed)

Checklist

  • Name PR "[WB-NNNN][WB-MMMM] Add support for..." similar to entries in CHANGELOG.md
  • Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

@raubitsj raubitsj changed the title wandb vendor gql and graphql [WB-5747] wandb vendor gql and graphql Feb 20, 2022
@codecov
Copy link

codecov bot commented Feb 20, 2022

Codecov Report

Merging #3266 (4809bd9) into master (3678f28) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3266      +/-   ##
==========================================
+ Coverage   79.92%   79.94%   +0.02%     
==========================================
  Files         213      213              
  Lines       27882    27882              
==========================================
+ Hits        22285    22291       +6     
+ Misses       5597     5591       -6     
Flag Coverage Δ
functest 56.62% <100.00%> (-0.03%) ⬇️
unittest 69.58% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/apis/normalize.py 68.42% <100.00%> (ø)
wandb/apis/public.py 81.81% <100.00%> (ø)
wandb/old/summary.py 53.60% <100.00%> (ø)
wandb/sdk/internal/internal_api.py 83.52% <100.00%> (ø)
wandb/sdk/verify/verify.py 32.23% <100.00%> (ø)
wandb/sdk/lib/sock_client.py 92.98% <0.00%> (-1.76%) ⬇️
wandb/sdk/service/server_sock.py 91.66% <0.00%> (-1.05%) ⬇️
wandb/sdk/lib/git.py 76.35% <0.00%> (-0.68%) ⬇️
wandb/sdk/internal/sender.py 91.71% <0.00%> (+0.27%) ⬆️
wandb/sdk/wandb_run.py 88.17% <0.00%> (+0.28%) ⬆️
... and 1 more

@raubitsj raubitsj marked this pull request as ready for review February 20, 2022 01:37
Copy link
Contributor

@vanpelt vanpelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 love the patch files 😍

@raubitsj raubitsj added this to the sdk-2022-03.1 milestone Feb 20, 2022
@raubitsj raubitsj merged commit 4fc2cb3 into master Feb 20, 2022
@raubitsj raubitsj deleted the vendor-gql-graphql branch February 20, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CLI] graphql-python / gql v 3.0.x support?
2 participants