Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WB-8591] Fix issue where sagemaker run ids break run queues #3290

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

KyleGoyette
Copy link
Contributor

@KyleGoyette KyleGoyette commented Feb 24, 2022

Fixes WB-8591

Description

Does not override the run id if its set by env var in sagemaker

Testing

How was this PR tested?

Checklist

  • Name PR "[WB-NNNN][WB-MMMM] Add support for..." similar to entries in CHANGELOG.md
  • Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #3290 (d36b873) into master (59c6229) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3290      +/-   ##
==========================================
+ Coverage   80.09%   80.10%   +0.01%     
==========================================
  Files         214      214              
  Lines       28167    28167              
==========================================
+ Hits        22559    22564       +5     
+ Misses       5608     5603       -5     
Flag Coverage Δ
functest 56.75% <0.00%> (+0.02%) ⬆️
unittest 69.33% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/integration/sagemaker/resources.py 100.00% <100.00%> (ø)
wandb/sdk/internal/sender.py 91.46% <0.00%> (-0.28%) ⬇️
wandb/sdk/lib/redirect.py 86.53% <0.00%> (-0.18%) ⬇️
wandb/sdk/lib/git.py 76.35% <0.00%> (ø)
wandb/sdk/launch/agent/agent.py 93.18% <0.00%> (+0.75%) ⬆️
wandb/sdk/lib/sock_client.py 94.73% <0.00%> (+1.75%) ⬆️
wandb/sdk/internal/meta.py 90.74% <0.00%> (+3.08%) ⬆️

@KyleGoyette KyleGoyette marked this pull request as draft February 24, 2022 17:03
@raubitsj raubitsj added this to the sdk-2022-03.1 milestone Feb 24, 2022
@raubitsj raubitsj self-requested a review February 24, 2022 19:23
@KyleGoyette KyleGoyette changed the title [] Fix issue where sagemaker run ids break run queues [WB-8591] Fix issue where sagemaker run ids break run queues Feb 24, 2022
@KyleGoyette KyleGoyette marked this pull request as ready for review February 24, 2022 19:24
@raubitsj raubitsj merged commit f115283 into master Feb 24, 2022
@raubitsj raubitsj deleted the launch/hotfix-sagemaker-run-ids-in-launch branch February 24, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants