Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding exception when using %%capture magic #3310

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

raubitsj
Copy link
Member

Fixes WB-8653

Description

What does the PR do?

Testing

How was this PR tested?

Checklist

  • Name PR "[WB-NNNN][WB-MMMM] Add support for..." similar to entries in CHANGELOG.md
  • Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

Copy link
Contributor

@kptkin kptkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #3310 (2ad2938) into master (66df6aa) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3310      +/-   ##
==========================================
+ Coverage   79.94%   80.01%   +0.06%     
==========================================
  Files         217      217              
  Lines       28439    28438       -1     
==========================================
+ Hits        22736    22755      +19     
+ Misses       5703     5683      -20     
Flag Coverage Δ
functest 56.48% <100.00%> (-0.02%) ⬇️
unittest 69.32% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/util.py 85.83% <100.00%> (+0.10%) ⬆️
wandb/filesync/step_prepare.py 92.85% <0.00%> (-1.43%) ⬇️
wandb/sdk/internal/stats.py 67.22% <0.00%> (-0.56%) ⬇️
wandb/sdk/lib/redirect.py 86.53% <0.00%> (-0.18%) ⬇️
wandb/sdk/lib/git.py 76.35% <0.00%> (ø)
wandb/sdk/internal/internal_api.py 83.52% <0.00%> (+1.54%) ⬆️
wandb/sdk/internal/meta.py 90.74% <0.00%> (+3.08%) ⬆️
wandb/sdk/internal/artifacts.py 86.31% <0.00%> (+6.31%) ⬆️

@raubitsj raubitsj merged commit 2e052e4 into master Feb 28, 2022
@raubitsj raubitsj deleted the wb-8653-stream-encoding branch February 28, 2022 23:20
@raubitsj raubitsj added this to the sdk-2022-03.1 milestone Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants