Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integrations): update gym integration to match last version #4363

Closed
wants to merge 2 commits into from

Conversation

younik
Copy link
Contributor

@younik younik commented Oct 8, 2022

Fixes #4305

Description

This PR fixes the gym integration after breaking changes in gym 0.26.

Testing

wandb.init(project="test",  monitor_gym=True)

env = RecordVideo(
    gym.make("CartPole-v1", render_mode="rgb_array"),
    "video"
)

env.reset()
for _ in range(100):
    env.step(env.action_space.sample())

Checklist

@github-actions github-actions bot added cc-fix and removed cc-fix labels Oct 8, 2022
@raubitsj raubitsj added this to the sdk-2022-11.1 milestone Oct 8, 2022
@raubitsj raubitsj modified the milestones: sdk-2022-11.1, sdk-2022-12.1 Nov 3, 2022
@Rocamonde
Copy link

Any estimate when this might get merged? Or at least be in beta state so I can pip install the branch.

@dmitryduev
Copy link
Member

Hey @younik, many thanks for your contribution! I pulled your changes into #4571 and added some logic so that it keeps working with older gym version. That PR is now merged and the change should make it into the release this week, so closing this one.

@dmitryduev dmitryduev closed this Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CLI]: Integration with OpenAI gym is broken due to missing ImageEncoder in the most recent gym version
4 participants