Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(launch): add error check for --build when resource=local-process #4513

Merged
merged 5 commits into from
Dec 7, 2022

Conversation

gtarpenning
Copy link
Contributor

https://wandb.atlassian.net/browse/WB-11575

Description

adds an error condition when the resource isn't compatible with the build flag

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@gtarpenning gtarpenning marked this pull request as ready for review November 21, 2022 23:11
Copy link
Contributor

@KyleGoyette KyleGoyette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to find other places to reject this in the future

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #4513 (dfe97d9) into main (cee3eac) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4513   +/-   ##
=======================================
  Coverage   83.04%   83.04%           
=======================================
  Files         267      267           
  Lines       33765    33767    +2     
=======================================
+ Hits        28039    28041    +2     
  Misses       5726     5726           
Flag Coverage Δ
functest 55.79% <0.00%> (+0.18%) ⬆️
unittest 73.40% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/launch/launch_add.py 100.00% <100.00%> (ø)
wandb/sdk/lib/printer.py 88.60% <0.00%> (-0.64%) ⬇️
wandb/sdk/internal/internal_api.py 89.27% <0.00%> (-0.52%) ⬇️
wandb/sdk/wandb_setup.py 88.44% <0.00%> (-0.51%) ⬇️
wandb/sdk/wandb_run.py 90.83% <0.00%> (-0.06%) ⬇️
wandb/sdk/lib/git.py 77.71% <0.00%> (ø)
wandb/integration/tensorboard/monkeypatch.py 93.82% <0.00%> (+2.46%) ⬆️
wandb/sdk/internal/system/system_info.py 91.55% <0.00%> (+3.24%) ⬆️

@gtarpenning gtarpenning force-pushed the griffin/launch/build-resource-fix branch from a2bf1cb to dfe97d9 Compare December 7, 2022 00:18
@gtarpenning gtarpenning merged commit bf68a19 into main Dec 7, 2022
@gtarpenning gtarpenning deleted the griffin/launch/build-resource-fix branch December 7, 2022 01:17
@kptkin kptkin added this to the sdk-2023-01.1 milestone Jan 5, 2023
@kptkin kptkin changed the title chore(launch): added error check for --build when resource=local-process chore(launch): add error check for --build when resource=local-process Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants