Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(sdk): update mypy to 0.991 #4546

Merged
merged 8 commits into from
Nov 29, 2022
Merged

style(sdk): update mypy to 0.991 #4546

merged 8 commits into from
Nov 29, 2022

Conversation

dmitryduev
Copy link
Member

@dmitryduev dmitryduev commented Nov 29, 2022

Description

...which also fixes the error seen in CI with the types-protobuf==4.21.0.1 release (see python/typeshed#8360 (comment))

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #4546 (77dc647) into main (cb77d21) will increase coverage by 0.02%.
The diff coverage is 97.95%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4546      +/-   ##
==========================================
+ Coverage   83.08%   83.10%   +0.02%     
==========================================
  Files         259      259              
  Lines       32979    32984       +5     
==========================================
+ Hits        27402    27413      +11     
+ Misses       5577     5571       -6     
Flag Coverage Δ
functest 56.95% <91.15%> (+0.28%) ⬆️
unittest 73.26% <93.19%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/apis/reports/reports.py 88.93% <ø> (ø)
wandb/apis/reports/util.py 81.31% <ø> (ø)
wandb/docker/__init__.py 81.25% <ø> (ø)
wandb/filesync/upload_job.py 70.73% <0.00%> (ø)
wandb/integration/kfp/kfp_patch.py 76.04% <ø> (ø)
wandb/sdk/data_types/base_types/wb_value.py 93.87% <ø> (ø)
wandb/sdk/data_types/video.py 77.87% <0.00%> (ø)
wandb/sdk/interface/interface.py 96.93% <ø> (ø)
wandb/sdk/interface/interface_grpc.py 60.98% <ø> (ø)
wandb/sdk/interface/interface_relay.py 100.00% <ø> (ø)
... and 68 more

wandb/apis/public.py Outdated Show resolved Hide resolved
@dmitryduev dmitryduev changed the title oh my, mypy, oh my style(sdk): update mypy to 0.991 Nov 29, 2022
@dmitryduev dmitryduev marked this pull request as ready for review November 29, 2022 08:15
@dmitryduev dmitryduev requested a review from a team as a code owner November 29, 2022 08:15
@dmitryduev dmitryduev enabled auto-merge (squash) November 29, 2022 16:50
Copy link
Contributor

@kptkin kptkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Contributor

@vanpelt vanpelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun 🙃

@dmitryduev dmitryduev merged commit 928b1a3 into main Nov 29, 2022
@dmitryduev dmitryduev deleted the mymy branch November 29, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants