Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(launch): fix env handling and node_selector handling #4555

Merged
merged 8 commits into from
Dec 8, 2022

Conversation

KyleGoyette
Copy link
Contributor

@KyleGoyette KyleGoyette commented Dec 1, 2022

Fixes WB-11685
Fixes #NNNN

Description

  • fixes nodeSelector handling
"node_selector": {"<label-name>": "<label-value"}
  • fixes env handling to be canonical for kubernetes
"env": [{"name": "ENV_NAME", "value": <value>}]

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #4555 (74548b0) into main (9742d22) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head 74548b0 differs from pull request most recent head 0014b40. Consider uploading reports for the commit 0014b40 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4555      +/-   ##
==========================================
+ Coverage   83.00%   83.11%   +0.10%     
==========================================
  Files         267      267              
  Lines       33768    33739      -29     
==========================================
+ Hits        28029    28041      +12     
+ Misses       5739     5698      -41     
Flag Coverage Δ
functest 55.84% <0.00%> (+0.06%) ⬆️
unittest 73.47% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/launch/runner/kubernetes.py 88.75% <100.00%> (ø)
wandb/sdk/internal/internal_api.py 89.79% <0.00%> (-0.26%) ⬇️
wandb/apis/public.py 81.87% <0.00%> (ø)
wandb/sdk/wandb_init.py 85.63% <0.00%> (ø)
wandb/sdk/launch/launch_add.py 100.00% <0.00%> (ø)
wandb/integration/gym/__init__.py 0.00% <0.00%> (ø)
wandb/integration/tensorboard/monkeypatch.py 91.35% <0.00%> (ø)
wandb/cli/cli.py 69.49% <0.00%> (+0.09%) ⬆️
wandb/sdk/wandb_setup.py 88.94% <0.00%> (+0.50%) ⬆️
wandb/sdk/internal/file_stream.py 89.86% <0.00%> (+1.01%) ⬆️
... and 5 more

@KyleGoyette KyleGoyette changed the title Launch/fix env handling fix(launch): Fix env handling and node_selector handling Dec 1, 2022
@github-actions github-actions bot added the cc-fix label Dec 1, 2022
@KyleGoyette KyleGoyette marked this pull request as ready for review December 1, 2022 21:44
@github-actions github-actions bot added cc-fix and removed cc-fix labels Dec 1, 2022
wandb/sdk/launch/runner/kubernetes.py Outdated Show resolved Hide resolved
wandb/sdk/launch/runner/kubernetes.py Show resolved Hide resolved
@KyleGoyette KyleGoyette enabled auto-merge (squash) December 8, 2022 17:48
@KyleGoyette KyleGoyette merged commit 519c5d5 into main Dec 8, 2022
@KyleGoyette KyleGoyette deleted the launch/fix-env-handling branch December 8, 2022 17:59
@kptkin kptkin added this to the sdk-2023-01.1 milestone Jan 5, 2023
@kptkin kptkin changed the title fix(launch): Fix env handling and node_selector handling fix(launch): fix env handling and node_selector handling Jan 5, 2023
@github-actions github-actions bot added cc-fix and removed cc-fix labels Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants