Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): change sklearn to scikit-learn in functional sacred test #4577

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

dmitryduev
Copy link
Member

Fixes WB-NNNN
Fixes #NNNN

Description

What does the PR do?

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@dmitryduev dmitryduev requested a review from a team December 6, 2022 08:21
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #4577 (59f9e40) into main (c38e770) will increase coverage by 0.30%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4577      +/-   ##
==========================================
+ Coverage   82.75%   83.05%   +0.30%     
==========================================
  Files         267      267              
  Lines       33765    33765              
==========================================
+ Hits        27943    28045     +102     
+ Misses       5822     5720     -102     
Flag Coverage Δ
functest 55.81% <ø> (+0.75%) ⬆️
unittest 73.40% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/lib/printer.py 88.60% <0.00%> (-0.64%) ⬇️
wandb/sdk/wandb_setup.py 88.44% <0.00%> (-0.51%) ⬇️
wandb/sdk/lib/git.py 77.71% <0.00%> (ø)
wandb/sdk/wandb_run.py 90.83% <0.00%> (ø)
wandb/integration/tensorboard/monkeypatch.py 91.35% <0.00%> (ø)
wandb/sdk/internal/tb_watcher.py 88.03% <0.00%> (+0.33%) ⬆️
wandb/sdk/service/server_sock.py 92.89% <0.00%> (+1.01%) ⬆️
wandb/sdk/lib/sock_client.py 94.17% <0.00%> (+1.05%) ⬆️
wandb/sdk/internal/file_pusher.py 74.64% <0.00%> (+1.40%) ⬆️
wandb/sdk/internal/system/system_info.py 91.55% <0.00%> (+3.24%) ⬆️
... and 5 more

@dmitryduev dmitryduev merged commit 508982e into main Dec 6, 2022
@dmitryduev dmitryduev deleted the sklearn-brownout2 branch December 6, 2022 17:21
@kptkin kptkin added this to the sdk-2023-01.1 milestone Jan 5, 2023
@kptkin kptkin changed the title chore(sdk): sklearn->scikit-learn in functional sacred test chore(sdk): change sklearn to scikit-learn in functional sacred test Jan 9, 2023
@github-actions github-actions bot added cc-chore and removed cc-chore labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants