Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): always print the traceback inside of the wandb.init context manager #4603

Merged
merged 6 commits into from
Sep 5, 2023

Conversation

kptkin
Copy link
Contributor

@kptkin kptkin commented Dec 9, 2022

Fixes WB-9886
Fixes WB-10858
Fixes #4225

Description

What does the PR do?

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@kptkin kptkin changed the title print the exception inside the context manager feature(sdk): always print the traceback inside of the wandb.init context manager Dec 9, 2022
@kptkin kptkin changed the title feature(sdk): always print the traceback inside of the wandb.init context manager feat(sdk): always print the traceback inside of the wandb.init context manager Dec 10, 2022
@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Merging #4603 (80f592e) into main (df2c7db) will decrease coverage by 0.08%.
Report is 1 commits behind head on main.
The diff coverage is 85.71%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4603      +/-   ##
==========================================
- Coverage   77.87%   77.80%   -0.08%     
==========================================
  Files         379      379              
  Lines       43746    43749       +3     
==========================================
- Hits        34069    34039      -30     
- Misses       9624     9657      +33     
  Partials       53       53              
Flag Coverage Δ
unittest 81.42% <85.71%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
wandb/sdk/wandb_run.py 91.03% <85.71%> (-0.23%) ⬇️

... and 14 files with indirect coverage changes

@github-actions github-actions bot removed the cc-feat label Mar 2, 2023
@kptkin kptkin added this to the sdk-2023-04.1 milestone Mar 2, 2023
@github-actions github-actions bot added cc-feat and removed cc-feat labels Jun 9, 2023
@darabos
Copy link

darabos commented Sep 4, 2023

Any chance to merge this tiny change? It's apparently been a problem for two years! (#2387) We just started our W&B trial and hit it on day 3. And the PR is right here! I've patched it in and it works great!

I tried sweeps from a notebook, and I was getting errors only in the sweep but not with normal runs. It looks like sweeps run in a separate process, so I can't use shared data. Which is fine. But this is probably a common way to get sweep-only issues, and they are painful to debug without the stack trace. Thanks for the PR! 👍

@kptkin kptkin marked this pull request as ready for review September 5, 2023 17:27
@kptkin kptkin added this to the sdk-2023-09.1 milestone Sep 5, 2023
@kptkin
Copy link
Contributor Author

kptkin commented Sep 5, 2023

Any chance to merge this tiny change? It's apparently been a problem for two years! (#2387) We just started our W&B trial and hit it on day 3. And the PR is right here! I've patched it in and it works great!

I tried sweeps from a notebook, and I was getting errors only in the sweep but not with normal runs. It looks like sweeps run in a separate process, so I can't use shared data. Which is fine. But this is probably a common way to get sweep-only issues, and they are painful to debug without the stack trace. Thanks for the PR! 👍

After this awesome request, we can't say no. So we will include it in the upcoming release. 😄

@darabos
Copy link

darabos commented Sep 5, 2023

After this awesome request, we can't say no. So we will include it in the upcoming release. 😄

Yes!!! Can't wait, thanks!

@dmitryduev dmitryduev merged commit 7da1dfa into main Sep 5, 2023
76 of 79 checks passed
@dmitryduev dmitryduev deleted the WB-9886 branch September 5, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CLI]: Exception traceback is (still) not visible in wandb log
4 participants