Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(launch): remove requirement to make target project match queue #4612

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

KyleGoyette
Copy link
Contributor

@KyleGoyette KyleGoyette commented Dec 12, 2022

Fixes WB-11511
Fixes #NNNN

Description

Removes the requirement to send the project to the same project as the queue

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #4612 (3f5857c) into main (dea67a1) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4612      +/-   ##
==========================================
+ Coverage   83.21%   83.23%   +0.02%     
==========================================
  Files         279      279              
  Lines       34909    34903       -6     
==========================================
+ Hits        29051    29053       +2     
+ Misses       5858     5850       -8     
Flag Coverage Δ
functest 56.10% <ø> (+0.03%) ⬆️
unittest 73.81% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/launch/agent/agent.py 91.24% <ø> (-0.37%) ⬇️
wandb/integration/tensorboard/monkeypatch.py 91.35% <0.00%> (-2.47%) ⬇️
wandb/filesync/step_prepare.py 93.67% <0.00%> (-1.27%) ⬇️
wandb/sdk/lib/git.py 77.71% <0.00%> (ø)
wandb/sdk/wandb_run.py 91.01% <0.00%> (+0.11%) ⬆️
wandb/util.py 87.70% <0.00%> (+0.40%) ⬆️
wandb/sdk/internal/system/system_info.py 91.55% <0.00%> (+3.24%) ⬆️

Copy link
Contributor

@gtarpenning gtarpenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming the code path in agent.py is only hit in this case. :)

@KyleGoyette KyleGoyette merged commit 67ea097 into main Dec 12, 2022
@KyleGoyette KyleGoyette deleted the launch/allow-any-project branch December 12, 2022 18:42
bcsherma pushed a commit that referenced this pull request Dec 19, 2022
@kptkin kptkin added this to the sdk-2023-01.1 milestone Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants