-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(sdk): improve file descriptor management #4617
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4617 +/- ##
==========================================
+ Coverage 83.19% 83.24% +0.05%
==========================================
Files 279 279
Lines 34903 34925 +22
==========================================
+ Hits 29038 29075 +37
+ Misses 5865 5850 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dmitryduev
changed the title
chore(sdk): default to lazily loading optional external modules
chore(sdk): improve file descriptor management
Dec 13, 2022
dmitryduev
commented
Dec 20, 2022
def get_module( | ||
name: str, | ||
required: Optional[Union[str, bool]] = None, | ||
lazy: bool = True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be True by default?
raubitsj
approved these changes
Dec 20, 2022
dmitryduev
changed the title
chore(sdk): improve file descriptor management
perf(sdk): improve file descriptor management
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WB-11427 (probably not fully, but this should be a good starting point)
Fixes #2825
Description
Reduce the default number of open file descriptors:
wandb.util.get_module
lazily load modules by defaultwandb.old.summary
was loadingh5py
, which many users will never need. It was accounting for ~40% of open file descriptors when you simply sayimport wandb
.With the above two improvements, for a simple script
junk.py
like this:goes down from ~115 to ~70.
Currently, for a script like this:
All the
debug-internal.log
files stay open until the service process exits -- fixed this.Testing
How was this PR tested?
Checklist