Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): make MetricsMonitor less verbose on errors #4618

Merged
merged 5 commits into from
Jan 4, 2023

Conversation

dmitryduev
Copy link
Member

@dmitryduev dmitryduev commented Dec 13, 2022

Description

Do not print to the terminal if wandb.sdk.internal.system.assets.interfaces.MetricsMonitor can't sample, serialize, or publish a metric -- there's usually nothing the user could do about it, so let's just write that to the log instead.

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@dmitryduev dmitryduev requested a review from a team December 13, 2022 08:17
@dmitryduev dmitryduev enabled auto-merge (squash) December 13, 2022 08:19
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #4618 (103621f) into main (d244d07) will increase coverage by 0.00%.
The diff coverage is 33.33%.

❗ Current head 103621f differs from pull request most recent head 2e0ef4b. Consider uploading reports for the commit 2e0ef4b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4618   +/-   ##
=======================================
  Coverage   83.30%   83.31%           
=======================================
  Files         280      280           
  Lines       34943    34939    -4     
=======================================
- Hits        29110    29109    -1     
+ Misses       5833     5830    -3     
Flag Coverage Δ
functest 55.90% <0.00%> (+0.02%) ⬆️
unittest 73.95% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/internal/system/assets/interfaces.py 91.86% <33.33%> (-0.10%) ⬇️
wandb/integration/tensorboard/monkeypatch.py 88.88% <0.00%> (-4.94%) ⬇️
wandb/sdk/lib/git.py 77.71% <0.00%> (-0.61%) ⬇️
wandb/sdk/wandb_run.py 90.68% <0.00%> (-0.18%) ⬇️
wandb/apis/public.py 81.92% <0.00%> (+0.02%) ⬆️
wandb/util.py 87.73% <0.00%> (+0.41%) ⬆️
wandb/sdk/lib/printer.py 89.24% <0.00%> (+0.63%) ⬆️
wandb/sdk/internal/system/system_info.py 91.55% <0.00%> (+3.24%) ⬆️

@dmitryduev dmitryduev added this to the sdk-2023-01.1 milestone Dec 13, 2022
@dmitryduev dmitryduev merged commit 12825a7 into main Jan 4, 2023
@dmitryduev dmitryduev deleted the quiet-metrics-monitor branch January 4, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants