fix(public-api): fix Job.call() using the wrong keyword (queue vs queue_name) when calling launch_add. #4625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4625 +/- ##
==========================================
+ Coverage 83.20% 83.23% +0.02%
==========================================
Files 279 279
Lines 34917 34917
==========================================
+ Hits 29054 29063 +9
+ Misses 5863 5854 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gtarpenning
reviewed
Dec 15, 2022
gtarpenning
reviewed
Dec 15, 2022
gtarpenning
requested changes
Dec 15, 2022
TimH98
force-pushed
the
job-call-use-queue-name
branch
from
a2d21d7
to
140e4a1
Compare
bcsherma
pushed a commit
that referenced
this pull request
Dec 19, 2022
…hen calling launch_add (#4625) * fix(public-api): Job uses queue_name keyword arg (instead of queue) when calling launch_add
kptkin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Job uses queue_name keyword arg (instead of queue) when calling launch_add
Fixes WB-11748
Description
Fixes
Job.call()using the wrong keyword (queuevsqueue_name) when calling launch_add.Testing
Unit test was added to verify
Job.call(). Runtox -e pylaunch38 tests/unit_tests/tests_launch/test_job.py