Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sweeps): sweeps schedulers handles multi word parameters #4640

Merged
merged 3 commits into from
Dec 16, 2022

Conversation

gtarpenning
Copy link
Contributor

@gtarpenning gtarpenning commented Dec 15, 2022

Fixes https://wandb.atlassian.net/browse/WB-11742

Description

We slightly modify an existing hack-y parameter ingesting mechanism to support multi-word params, exposed when pushing to a queue that had spaces in the name.

This does not solve the case where backslashes are in the name, we escape them properly on the backend, but then assume they are already escaped when printing, resulting in half as many backslashes. We should probably just tell users in the frontend they can't use backslashes. I don't think XSS is possible here but why would anyone want a backslash in the name if they weren't doing something nefarious?

@github-actions github-actions bot added cc-fix and removed cc-fix labels Dec 15, 2022
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #4640 (272ed98) into main (4c9654f) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 272ed98 differs from pull request most recent head aa97854. Consider uploading reports for the commit aa97854 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4640      +/-   ##
==========================================
+ Coverage   83.17%   83.21%   +0.04%     
==========================================
  Files         279      279              
  Lines       34917    34917              
==========================================
+ Hits        29041    29057      +16     
+ Misses       5876     5860      -16     
Flag Coverage Δ
functest 56.07% <ø> (+0.03%) ⬆️
unittest 73.78% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/cli/cli.py 69.30% <ø> (ø)
wandb/filesync/step_prepare.py 93.67% <0.00%> (-1.27%) ⬇️
wandb/sdk/lib/git.py 77.71% <0.00%> (-0.61%) ⬇️
wandb/apis/public.py 81.87% <0.00%> (-0.10%) ⬇️
wandb/sdk/wandb_run.py 90.83% <0.00%> (+0.82%) ⬆️
wandb/__init__.py 92.30% <0.00%> (+0.96%) ⬆️
wandb/sdk/internal/system/system_info.py 91.55% <0.00%> (+3.24%) ⬆️

@gtarpenning gtarpenning marked this pull request as ready for review December 15, 2022 17:16
@gtarpenning gtarpenning enabled auto-merge (squash) December 16, 2022 23:53
@gtarpenning gtarpenning merged commit d4a92c0 into main Dec 16, 2022
@gtarpenning gtarpenning deleted the griffin/launch/agent-now-handles-spaces-in-queue branch December 16, 2022 23:59
@kptkin kptkin added this to the sdk-2023-01.1 milestone Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants