fix(launch): allow spaces in requirements file, remove duplicate wandb bootstrap file #4647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WB-11794
Description
_wandb_bootstrap.py
was failing to handle the case where a requirement is specified asxyz @ ...
due to spaces being present. This change removes the spaces, fixing the behavior.Also removed
sdk/launch/templates/_wandb_bootstrap.py
, since it was a duplicate ofsdk/launch/builder/templates/_wandb_bootstrap.py
Testing
wandb/sdk/launch/builder/templates/
requirements.frozen.txt
file with the contents:python _wandb_bootstrap.py
pip list | grep 'example'
, confirm that the three example packages were installedpip uninstall -r requirements.frozen.txt -y
Also ran
tox -e pylaunch38