Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sdk): combine _safe_mkdirs with mkdir_exist_ok #4650

Merged
merged 20 commits into from
Dec 20, 2022

Conversation

moredatarequired
Copy link
Contributor

@moredatarequired moredatarequired commented Dec 16, 2022

Fixes WB-11844

These aren't exactly identical helper functions, but they're used identically (in particular, there are no callers that make use of the returned boolean value from mkdir_exist_ok). This combines them, using the _safe_mkdirs code and location (lib.filesystem) but using the name of the more commonly used mkdir_exist_ok.

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #4650 (b660806) into main (77f2c8c) will increase coverage by 0.01%.
The diff coverage is 87.27%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4650      +/-   ##
==========================================
+ Coverage   83.23%   83.25%   +0.01%     
==========================================
  Files         279      279              
  Lines       34927    34927              
==========================================
+ Hits        29071    29077       +6     
+ Misses       5856     5850       -6     
Flag Coverage Δ
functest 55.94% <70.90%> (+0.02%) ⬆️
unittest 73.81% <85.45%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/old/core.py 56.92% <0.00%> (-0.89%) ⬇️
wandb/jupyter.py 56.06% <50.00%> (+0.16%) ⬆️
wandb/sdk/data_types/video.py 78.07% <50.00%> (+0.19%) ⬆️
wandb/sdk/wandb_artifacts.py 83.71% <66.66%> (+0.01%) ⬆️
wandb/cli/cli.py 69.33% <75.00%> (+0.02%) ⬆️
wandb/sdk/lib/filesystem.py 95.91% <80.00%> (+3.19%) ⬆️
wandb/apis/public.py 81.96% <100.00%> (ø)
wandb/data_types.py 82.88% <100.00%> (+0.01%) ⬆️
wandb/filesync/step_checksum.py 92.53% <100.00%> (+0.11%) ⬆️
wandb/old/settings.py 92.50% <100.00%> (+0.09%) ⬆️
... and 18 more

@moredatarequired moredatarequired marked this pull request as ready for review December 16, 2022 08:16
@raubitsj raubitsj self-requested a review December 20, 2022 21:57
@moredatarequired moredatarequired merged commit a76ddce into main Dec 20, 2022
@moredatarequired moredatarequired deleted the paths/consolidate-mkdir branch December 20, 2022 22:07
@kptkin kptkin added this to the sdk-2023-01.1 milestone Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants