Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(launch): auto create job artifacts from runs with required ingredients #4660

Merged
merged 40 commits into from
Jan 5, 2023

Conversation

KyleGoyette
Copy link
Contributor

@KyleGoyette KyleGoyette commented Dec 19, 2022

Fixes WB-11453

Description

Moves job creation from the user process to the service process. So when a user runs a run with the ingredients for a job, the run automatically creates a job artifact, unless that run used an artifact of type job

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #4660 (27b2fe2) into main (3c04cf5) will increase coverage by 0.34%.
The diff coverage is 98.43%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4660      +/-   ##
==========================================
+ Coverage   83.29%   83.63%   +0.34%     
==========================================
  Files         280      281       +1     
  Lines       34946    35096     +150     
==========================================
+ Hits        29108    29354     +246     
+ Misses       5838     5742      -96     
Flag Coverage Δ
functest 56.10% <95.78%> (+0.47%) ⬆️
unittest 74.02% <90.62%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/wandb_settings.py 94.60% <ø> (+0.13%) ⬆️
wandb/sdk/internal/sender.py 92.37% <96.42%> (+1.27%) ⬆️
wandb/sdk/internal/job_builder.py 98.57% <98.57%> (ø)
wandb/sdk/interface/interface.py 96.96% <100.00%> (+0.03%) ⬆️
wandb/sdk/interface/interface_grpc.py 68.28% <100.00%> (+7.29%) ⬆️
wandb/sdk/interface/interface_shared.py 90.56% <100.00%> (+3.99%) ⬆️
wandb/sdk/internal/handler.py 94.87% <100.00%> (+3.87%) ⬆️
wandb/sdk/service/server_grpc.py 69.70% <100.00%> (+5.02%) ⬆️
wandb/sdk/wandb_run.py 90.71% <100.00%> (-0.21%) ⬇️
wandb/integration/tensorboard/monkeypatch.py 88.88% <0.00%> (-2.47%) ⬇️
... and 13 more

@github-actions github-actions bot added cc-feat and removed cc-feat labels Dec 21, 2022
@KyleGoyette KyleGoyette requested review from kptkin and removed request for gtarpenning December 28, 2022 19:10
Copy link
Contributor

@kptkin kptkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to me!

@raubitsj raubitsj merged commit 70f4f1e into main Jan 5, 2023
@raubitsj raubitsj deleted the launch/jobs-made-in-service branch January 5, 2023 02:47
@github-actions github-actions bot added cc-feat and removed cc-feat labels Jan 5, 2023
@kptkin kptkin changed the title feat(launch): Auto create job artifacts from runs with required ingredients feat(launch): auto create job artifacts from runs with required ingredients Jan 5, 2023
@github-actions github-actions bot added cc-feat and removed cc-feat labels Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants