Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): remove unused fields from a filesync message #4662

Merged
merged 3 commits into from
Dec 20, 2022

Conversation

speezepearson
Copy link
Contributor

Description

StepUpload.RequestUpload is only instantiated by FilePusher.file_changed; and half of the arguments to file_changed are never used. (A couple of these args used to be used, but were removed in 949013a in a huge mid-2020 Artifacts-overhaul.)

Testing

If I missed a place these args/fields are used, Mypy will catch it.

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@e860271). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 50d1550 differs from pull request most recent head 62d7f7e. Consider uploading reports for the commit 62d7f7e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4662   +/-   ##
=======================================
  Coverage        ?   83.23%           
=======================================
  Files           ?      279           
  Lines           ?    34910           
  Branches        ?        0           
=======================================
  Hits            ?    29056           
  Misses          ?     5854           
  Partials        ?        0           
Flag Coverage Δ
functest 56.07% <ø> (?)
unittest 73.78% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/filesync/step_checksum.py 92.42% <ø> (ø)
wandb/sdk/internal/file_pusher.py 74.64% <ø> (ø)

@dmitryduev dmitryduev enabled auto-merge (squash) December 20, 2022 20:08
@dmitryduev dmitryduev merged commit af42d84 into main Dec 20, 2022
@dmitryduev dmitryduev deleted the spencerpearson/deadcode branch December 20, 2022 20:20
@kptkin kptkin added this to the sdk-2023-01.1 milestone Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants