Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): use pytest tmp_path so we can inspect failures #4664

Merged
merged 3 commits into from
Dec 20, 2022

Conversation

raubitsj
Copy link
Member

@raubitsj raubitsj commented Dec 20, 2022

Description

Once this pytest feature gets out, then we can use temp dir retention policies based on failures etc:
pytest-dev/pytest#10442

Testing

Manual test to make sure directory exists after pytest exit
By default pytest keeps around 3 sessions.

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@raubitsj raubitsj changed the title Use pytest temp_dir so we can inspect failures chore(sdk): use pytest temp_dir so we can inspect failures Dec 20, 2022
@raubitsj raubitsj changed the title chore(sdk): use pytest temp_dir so we can inspect failures chore(sdk): use pytest tmp_path so we can inspect failures Dec 20, 2022
raubitsj added a commit that referenced this pull request Dec 20, 2022
raubitsj added a commit that referenced this pull request Dec 20, 2022
raubitsj added a commit that referenced this pull request Dec 20, 2022
@raubitsj raubitsj marked this pull request as ready for review December 20, 2022 02:04
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #4664 (0fa824d) into main (709a60d) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4664   +/-   ##
=======================================
  Coverage   83.22%   83.22%           
=======================================
  Files         279      279           
  Lines       34917    34917           
=======================================
+ Hits        29060    29061    +1     
+ Misses       5857     5856    -1     
Flag Coverage Δ
functest 56.08% <ø> (+0.03%) ⬆️
unittest 73.81% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/internal/file_stream.py 88.85% <0.00%> (-1.02%) ⬇️
wandb/util.py 87.44% <0.00%> (-0.41%) ⬇️
wandb/sdk/lib/git.py 77.71% <0.00%> (ø)
wandb/sdk/wandb_setup.py 88.94% <0.00%> (+0.50%) ⬆️
wandb/sdk/lib/sock_client.py 94.17% <0.00%> (+1.05%) ⬆️
wandb/sdk/internal/system/system_info.py 91.55% <0.00%> (+3.24%) ⬆️

Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, thanks!

@dmitryduev dmitryduev merged commit cd0ac18 into main Dec 20, 2022
@dmitryduev dmitryduev deleted the pytest-tmpdir branch December 20, 2022 17:10
@kptkin kptkin added this to the sdk-2023-01.1 milestone Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants