Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): add more flow control telemetry #4739

Merged
merged 5 commits into from
Jan 9, 2023
Merged

Conversation

raubitsj
Copy link
Member

@raubitsj raubitsj commented Jan 7, 2023

Description

Allows tracking of how flow control was configured by users. adds a disabled and custom telemetry.

Testing

yea

@codecov
Copy link

codecov bot commented Jan 7, 2023

Codecov Report

Merging #4739 (f317a56) into main (e6557ce) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head f317a56 differs from pull request most recent head 4fd2903. Consider uploading reports for the commit 4fd2903 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4739      +/-   ##
==========================================
+ Coverage   83.83%   83.86%   +0.02%     
==========================================
  Files         285      285              
  Lines       35984    35993       +9     
==========================================
+ Hits        30168    30186      +18     
+ Misses       5816     5807       -9     
Flag Coverage Δ
functest 56.93% <100.00%> (+0.03%) ⬆️
unittest 74.24% <81.81%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/internal/settings_static.py 94.59% <100.00%> (+0.15%) ⬆️
wandb/sdk/internal/writer.py 96.82% <100.00%> (+0.02%) ⬆️
wandb/sdk/wandb_init.py 86.65% <100.00%> (+0.09%) ⬆️
wandb/sdk/wandb_settings.py 94.93% <100.00%> (+0.01%) ⬆️
wandb/sdk/lib/printer.py 89.24% <0.00%> (-0.64%) ⬇️
wandb/sdk/wandb_run.py 90.72% <0.00%> (-0.06%) ⬇️
wandb/sdk/lib/git.py 77.71% <0.00%> (ø)
wandb/cli/cli.py 69.32% <0.00%> (+0.09%) ⬆️
wandb/sdk/internal/internal_api.py 90.19% <0.00%> (+0.49%) ⬆️
wandb/filesync/step_prepare.py 94.93% <0.00%> (+1.26%) ⬆️
... and 1 more

@raubitsj raubitsj added this to the sdk-2023-01.1 milestone Jan 9, 2023
@raubitsj raubitsj marked this pull request as ready for review January 9, 2023 17:39
@raubitsj raubitsj requested a review from a team January 9, 2023 17:39
@github-actions github-actions bot added cc-chore and removed cc-chore labels Jan 9, 2023
@raubitsj raubitsj enabled auto-merge (squash) January 9, 2023 18:24
@raubitsj raubitsj disabled auto-merge January 9, 2023 18:28
@raubitsj raubitsj enabled auto-merge (squash) January 9, 2023 18:41
@raubitsj raubitsj merged commit 0820dad into main Jan 9, 2023
@raubitsj raubitsj deleted the flow-telemetry-tests branch January 9, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants