Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): add settings and debug for service startup issues (wait_for_ports) #4749

Merged
merged 9 commits into from
Jan 10, 2023

Conversation

raubitsj
Copy link
Member

@raubitsj raubitsj commented Jan 9, 2023

Description

Add new setting to control wait for port time and debug messages to find out timings of what might be going wrong.

Testing

manually

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #4749 (28ebd3f) into main (361524c) will increase coverage by 0.02%.
The diff coverage is 89.13%.

❗ Current head 28ebd3f differs from pull request most recent head 173cb7b. Consider uploading reports for the commit 173cb7b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4749      +/-   ##
==========================================
+ Coverage   83.84%   83.86%   +0.02%     
==========================================
  Files         285      286       +1     
  Lines       35995    36029      +34     
==========================================
+ Hits        30180    30216      +36     
+ Misses       5815     5813       -2     
Flag Coverage Δ
functest 56.98% <89.13%> (+0.07%) ⬆️
unittest 74.09% <67.39%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/service/_startup_debug.py 66.66% <66.66%> (ø)
wandb/sdk/service/server.py 84.82% <90.90%> (+0.66%) ⬆️
wandb/sdk/service/service.py 89.69% <95.00%> (+0.40%) ⬆️
wandb/sdk/wandb_manager.py 94.11% <100.00%> (+0.04%) ⬆️
wandb/sdk/wandb_settings.py 94.93% <100.00%> (+<0.01%) ⬆️
wandb/sdk/wandb_setup.py 88.88% <100.00%> (+0.44%) ⬆️
wandb/sdk/interface/interface_shared.py 90.78% <0.00%> (-0.71%) ⬇️
wandb/sdk/lib/mailbox.py 93.26% <0.00%> (-0.33%) ⬇️
wandb/sdk/lib/git.py 77.71% <0.00%> (ø)
... and 3 more

@kptkin kptkin added this to the sdk-2023-01.1 milestone Jan 9, 2023
@raubitsj raubitsj marked this pull request as ready for review January 9, 2023 23:43
@raubitsj raubitsj requested a review from a team January 9, 2023 23:45
@raubitsj raubitsj changed the title Add _service_wait setting and debug chore: add settings and debug for service startup issues (wait_for_ports) Jan 9, 2023
@github-actions github-actions bot added cc-chore and removed cc-chore labels Jan 9, 2023
@raubitsj raubitsj changed the title chore: add settings and debug for service startup issues (wait_for_ports) chore(sdk): add settings and debug for service startup issues (wait_for_ports) Jan 10, 2023
@raubitsj raubitsj merged commit 2fde46d into main Jan 10, 2023
@raubitsj raubitsj deleted the wait-for-ports branch January 10, 2023 01:28
kptkin pushed a commit that referenced this pull request Jan 10, 2023
@davidgilbertson
Copy link

Hi @raubitsj I was just about to create an issue for "slow init/finish times" but found this PR. Does this mean the team is working to improve the performance?
Also, is a wandb.init() time of 2 seconds and a wandb.finish() time of 5.5 seconds expected? Or is there something I can do to improve this? I'm not running a local server, and this is when not even logging anything at all, so I assume these times could be brought down to a few hundred milliseconds easily enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants