Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(launch): remove args from jobs #4750

Merged
merged 7 commits into from
Jan 10, 2023
Merged

fix(launch): remove args from jobs #4750

merged 7 commits into from
Jan 10, 2023

Conversation

KyleGoyette
Copy link
Contributor

@KyleGoyette KyleGoyette commented Jan 9, 2023

Description

  • disables job creation in sweeps
  • pulls args from job object

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@github-actions github-actions bot added the cc-fix label Jan 9, 2023
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #4750 (6deeaf3) into main (2fde46d) will increase coverage by 0.03%.
The diff coverage is 92.85%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4750      +/-   ##
==========================================
+ Coverage   83.83%   83.86%   +0.03%     
==========================================
  Files         286      286              
  Lines       36027    36025       -2     
==========================================
+ Hits        30202    30214      +12     
+ Misses       5825     5811      -14     
Flag Coverage Δ
functest 56.93% <91.66%> (-0.01%) ⬇️
unittest 74.10% <85.71%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/internal/sender.py 93.06% <75.00%> (+0.01%) ⬆️
wandb/sdk/internal/job_builder.py 98.52% <100.00%> (-0.05%) ⬇️
wandb/sdk/lib/printer.py 89.24% <0.00%> (-0.64%) ⬇️
wandb/sdk/wandb_run.py 90.72% <0.00%> (-0.12%) ⬇️
wandb/apis/public.py 81.87% <0.00%> (-0.05%) ⬇️
wandb/sdk/lib/git.py 77.71% <0.00%> (ø)
wandb/sdk/lib/mailbox.py 93.58% <0.00%> (+0.32%) ⬆️
wandb/sdk/interface/artifacts.py 79.15% <0.00%> (+0.35%) ⬆️
wandb/sdk/internal/internal_api.py 90.19% <0.00%> (+0.49%) ⬆️
wandb/sdk/wandb_setup.py 88.88% <0.00%> (+0.50%) ⬆️
... and 4 more

@KyleGoyette KyleGoyette marked this pull request as ready for review January 9, 2023 22:56
@github-actions github-actions bot added cc-fix and removed cc-fix labels Jan 9, 2023
@raubitsj raubitsj added this to the sdk-2023-01.1 milestone Jan 10, 2023
@raubitsj raubitsj merged commit d17fc52 into main Jan 10, 2023
@raubitsj raubitsj deleted the launch/no-args-in-job-def branch January 10, 2023 01:54
kptkin pushed a commit that referenced this pull request Jan 10, 2023
@kptkin kptkin changed the title fix(launch): Remove args from jobs fix(launch): remove args from jobs Jan 10, 2023
@github-actions github-actions bot added cc-fix and removed cc-fix labels Jan 10, 2023
kptkin pushed a commit that referenced this pull request Jan 11, 2023
kptkin pushed a commit that referenced this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants