Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sdk): fix AWS Trainium test #4753

Merged
merged 6 commits into from
Jan 10, 2023
Merged

test(sdk): fix AWS Trainium test #4753

merged 6 commits into from
Jan 10, 2023

Conversation

dmitryduev
Copy link
Member

@dmitryduev dmitryduev commented Jan 9, 2023

Description

  • tests/unit_tests/test_system_metrics_trainium.py::test_trainium was causing trouble on the CI apparently bc I wasn't shutting down neuron_monitor_mock properly.
  • added more guardrails around the Trainium monitor internals.

Testing

Checklist

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #4753 (cb370fb) into main (d17fc52) will decrease coverage by 0.04%.
The diff coverage is 7.14%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4753      +/-   ##
==========================================
- Coverage   83.86%   83.81%   -0.05%     
==========================================
  Files         286      286              
  Lines       36025    36028       +3     
==========================================
- Hits        30213    30198      -15     
- Misses       5812     5830      +18     
Flag Coverage Δ
functest 56.91% <7.14%> (+<0.01%) ⬆️
unittest 74.02% <7.14%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/internal/system/assets/trainium.py 76.47% <7.14%> (-2.58%) ⬇️
wandb/sdk/internal/artifacts.py 83.48% <0.00%> (-4.59%) ⬇️
wandb/sdk/internal/context.py 97.91% <0.00%> (-2.09%) ⬇️
wandb/sdk/internal/internal_api.py 88.83% <0.00%> (-1.37%) ⬇️
wandb/sdk/lib/printer.py 89.24% <0.00%> (-0.64%) ⬇️
wandb/sdk/wandb_init.py 86.52% <0.00%> (-0.55%) ⬇️
wandb/sdk/wandb_setup.py 88.38% <0.00%> (-0.51%) ⬇️
wandb/sdk/wandb_run.py 90.78% <0.00%> (-0.06%) ⬇️
wandb/sdk/lib/git.py 77.71% <0.00%> (ø)
wandb/util.py 87.68% <0.00%> (+0.41%) ⬆️
... and 3 more

@dmitryduev dmitryduev changed the title test(sdk): DNM stress-test-run CI for flow control test(sdk): DNM stress-test-run CI for 0.13.8 Jan 10, 2023
@github-actions github-actions bot added cc-test and removed cc-test labels Jan 10, 2023
@dmitryduev dmitryduev changed the title test(sdk): DNM stress-test-run CI for 0.13.8 test(sdk): fix AWS Trainium test Jan 10, 2023
@github-actions github-actions bot added cc-test and removed cc-test labels Jan 10, 2023
@dmitryduev dmitryduev marked this pull request as ready for review January 10, 2023 06:18
@dmitryduev dmitryduev requested a review from a team January 10, 2023 06:18
@github-actions github-actions bot added cc-test and removed cc-test labels Jan 10, 2023
@dmitryduev dmitryduev merged commit f746436 into main Jan 10, 2023
@dmitryduev dmitryduev deleted the ci-flow-control-test branch January 10, 2023 06:44
@dmitryduev dmitryduev mentioned this pull request Jan 10, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants