Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): fix status checker thread issue when user process exits without finish() #4761

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

raubitsj
Copy link
Member

Fixes WB-NNNN
Fixes #NNNN

Description

What does the PR do?

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@dmitryduev dmitryduev requested a review from a team January 10, 2023 18:06
@raubitsj raubitsj changed the title Fix loop checkers chore(sdk): fix status checker thread issue when user process exits without finish() Jan 10, 2023
@raubitsj raubitsj marked this pull request as ready for review January 10, 2023 18:10
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #4761 (a2567d1) into main (f746436) will increase coverage by 0.07%.
The diff coverage is 60.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4761      +/-   ##
==========================================
+ Coverage   83.83%   83.90%   +0.07%     
==========================================
  Files         286      286              
  Lines       36028    36032       +4     
==========================================
+ Hits        30203    30232      +29     
+ Misses       5825     5800      -25     
Flag Coverage Δ
functest 56.92% <60.00%> (+0.03%) ⬆️
unittest 74.12% <60.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/wandb_run.py 90.68% <60.00%> (-0.04%) ⬇️
wandb/sdk/interface/interface_shared.py 90.78% <0.00%> (-0.71%) ⬇️
wandb/sdk/lib/mailbox.py 93.26% <0.00%> (-0.33%) ⬇️
wandb/sdk/lib/git.py 77.71% <0.00%> (ø)
wandb/util.py 87.68% <0.00%> (+0.41%) ⬆️
wandb/sdk/internal/internal_api.py 90.19% <0.00%> (+0.49%) ⬆️
wandb/sdk/wandb_setup.py 88.88% <0.00%> (+0.50%) ⬆️
wandb/sdk/lib/sock_client.py 94.17% <0.00%> (+1.05%) ⬆️
wandb/sdk/internal/context.py 100.00% <0.00%> (+2.08%) ⬆️
... and 2 more

@raubitsj raubitsj merged commit 713aa4c into main Jan 10, 2023
@raubitsj raubitsj deleted the fix-loop-checkers branch January 10, 2023 18:53
@raubitsj raubitsj added this to the sdk-2023-01.1 milestone Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants