Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): add support for gymnasium env monitoring, in addition to gym #5008

Merged
merged 4 commits into from
Mar 2, 2023

Conversation

dmitryduev
Copy link
Member

@dmitryduev dmitryduev commented Feb 21, 2023

Fixes #4985

Description

The gym library is not maintained anymore, gymnasium is the drop-in replacement. This PR makes our current gym monitoring work in case the user has gymnasium installed, without changing the current API.

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@dmitryduev dmitryduev requested a review from a team February 21, 2023 20:41
@github-actions github-actions bot added cc-feat and removed cc-feat labels Feb 21, 2023
@dmitryduev dmitryduev added this to the sdk-2023-03.1 milestone Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #5008 (fe44969) into main (58f4ec9) will increase coverage by 0.35%.
The diff coverage is 0.00%.

❗ Current head fe44969 differs from pull request most recent head bdd9e7c. Consider uploading reports for the commit bdd9e7c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5008      +/-   ##
==========================================
+ Coverage   83.52%   83.87%   +0.35%     
==========================================
  Files         295      287       -8     
  Lines       37366    36683     -683     
==========================================
- Hits        31210    30769     -441     
+ Misses       6156     5914     -242     
Flag Coverage Δ
functest 56.73% <0.00%> (+0.10%) ⬆️
unittest 73.75% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/integration/gym/__init__.py 0.00% <0.00%> (ø)
wandb/filesync/step_prepare.py 93.67% <0.00%> (-6.33%) ⬇️
wandb/sdk/interface/artifacts.py 79.00% <0.00%> (-4.05%) ⬇️
wandb/sdk/internal/context.py 97.91% <0.00%> (-2.09%) ⬇️
wandb/sdk/interface/interface_shared.py 90.90% <0.00%> (-0.94%) ⬇️
wandb/sdk/lib/server.py 81.25% <0.00%> (-0.57%) ⬇️
wandb/sdk/lib/sock_client.py 92.59% <0.00%> (-0.53%) ⬇️
wandb/sdk/wandb_artifacts.py 85.18% <0.00%> (-0.53%) ⬇️
wandb/util.py 87.20% <0.00%> (-0.42%) ⬇️
wandb/sdk/launch/launch_add.py 88.13% <0.00%> (-0.39%) ⬇️
... and 155 more

@jkterry1
Copy link

Given that Gym will no longer be maintained and all the major projects have agreed to switch over, you may want to do the opposite (e.g. use Gymnasium and make your monitoring work for Gym if they have it installed instead) for better future proofing

@github-actions github-actions bot added cc-feat and removed cc-feat labels Mar 2, 2023
@dmitryduev dmitryduev enabled auto-merge (squash) March 2, 2023 22:32
@dmitryduev dmitryduev merged commit c294603 into main Mar 2, 2023
@dmitryduev dmitryduev deleted the gymnasium branch March 2, 2023 22:43
ssisk pushed a commit that referenced this pull request Mar 7, 2023
…ym (#5008)

* feat(sdk): add support for gymnasium env monitoring, in addition to gym
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add Gymnasium support
3 participants