Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): unify offline and online mode during init and fix multiprocess attach #5296

Merged
merged 27 commits into from Jun 1, 2023

Conversation

kptkin
Copy link
Contributor

@kptkin kptkin commented Apr 5, 2023

…xisting run (#5144)

Fixes WB-NNNN
Fixes #5071

Description

What does the PR do?

TODO:

  • unify deliver_run and publish_run
  • move attach handling from sender to handler
  • unify offline_run and online_run in the run class

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@github-actions github-actions bot added the cc-fix label Apr 5, 2023
@github-actions github-actions bot added cc-fix and removed cc-fix labels Apr 5, 2023
@github-actions github-actions bot added cc-fix and removed cc-fix labels Apr 5, 2023
wandb/analytics/sentry.py Outdated Show resolved Hide resolved
wandb/sdk/wandb_run.py Outdated Show resolved Hide resolved
@kptkin kptkin changed the title fix(sdk): fix timeout in offline mode when trying to attach to an e… fix(sdk): fix attach in offline mode and unify offline and online mode during init Apr 5, 2023
@github-actions github-actions bot added cc-fix and removed cc-fix labels Apr 5, 2023
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #5296 (3c70bb8) into main (ef309c3) will increase coverage by 0.00%.
The diff coverage is 96.82%.

❗ Current head 3c70bb8 differs from pull request most recent head d8cf045. Consider uploading reports for the commit d8cf045 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5296   +/-   ##
=======================================
  Coverage   82.47%   82.48%           
=======================================
  Files         322      321    -1     
  Lines       39235    39180   -55     
=======================================
- Hits        32360    32317   -43     
+ Misses       6875     6863   -12     
Flag Coverage Δ
functest 56.16% <79.36%> (+0.01%) ⬆️
unittest 71.78% <76.19%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/internal/sender.py 93.12% <ø> (-0.07%) ⬇️
wandb/sdk/wandb_init.py 87.32% <93.33%> (+0.17%) ⬆️
wandb/sdk/interface/interface.py 96.12% <100.00%> (+0.02%) ⬆️
wandb/sdk/internal/handler.py 94.94% <100.00%> (+0.09%) ⬆️
wandb/sdk/wandb_run.py 91.79% <100.00%> (-0.04%) ⬇️

... and 24 files with indirect coverage changes

@kptkin kptkin added this to the sdk-2023-05.1 milestone Apr 12, 2023
wandb/sdk/wandb_init.py Outdated Show resolved Hide resolved
@kptkin kptkin requested a review from raubitsj April 26, 2023 19:15
@raubitsj raubitsj self-assigned this Apr 28, 2023
@raubitsj raubitsj modified the milestones: sdk-2023-05.1, sdk-2023-06.1 Apr 28, 2023
Copy link
Member

@raubitsj raubitsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM gnarly codepath, nice fix

wandb/sdk/wandb_init.py Outdated Show resolved Hide resolved
wandb/sdk/wandb_init.py Outdated Show resolved Hide resolved
@raubitsj raubitsj assigned kptkin and unassigned raubitsj May 31, 2023
@kptkin
Copy link
Contributor Author

kptkin commented Jun 1, 2023

/suggest-title

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Suggested title:

fix(sdk): unify offline and online mode during init and fix multiprocess attach

@kptkin kptkin changed the title fix(sdk): fix attach in offline mode and unify offline and online mode during init fix(sdk): unify offline and online mode during init and fix multiprocess attach Jun 1, 2023
@github-actions github-actions bot added cc-fix and removed cc-fix labels Jun 1, 2023
@kptkin kptkin enabled auto-merge (squash) June 1, 2023 17:19
@kptkin kptkin merged commit 0876aef into main Jun 1, 2023
52 of 54 checks passed
@kptkin kptkin deleted the attach-offline-1 branch June 1, 2023 17:28
@github-actions github-actions bot added cc-fix and removed cc-fix labels Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CLI]: wandb.errors.UsageError: Timeout attaching to run when in offline mode
3 participants