New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): unify offline and online mode during init and fix multiprocess attach #5296
Conversation
offline
mode when trying to attach to an e…
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5296 +/- ##
=======================================
Coverage 82.47% 82.48%
=======================================
Files 322 321 -1
Lines 39235 39180 -55
=======================================
- Hits 32360 32317 -43
+ Misses 6875 6863 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM gnarly codepath, nice fix
/suggest-title |
Suggested title:
|
…xisting run (#5144)
Fixes WB-NNNN
Fixes #5071
Description
What does the PR do?
TODO:
deliver_run
andpublish_run
Testing
How was this PR tested?
Checklist